Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2741533003: [Telemetry] Move from telemetry/trace_data to tracing/trace_data in chromium (Closed)

Created:
3 years, 9 months ago by rnephew (Reviews Here)
Modified:
3 years, 9 months ago
Reviewers:
nednguyen, bustamante
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Move from telemetry/trace_data to tracing/trace_data in chromium This is the chromium side version of https://codereview.chromium.org/2736903005 Review-Url: https://codereview.chromium.org/2741533003 Cr-Commit-Position: refs/heads/master@{#455924} Committed: https://chromium.googlesource.com/chromium/src/+/aa1f961e37c8778191049bca02608cc54f389366

Patch Set 1 #

Patch Set 2 : fix presubmit #

Patch Set 3 : renable test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M tools/chrome_proxy/common/inspector_network.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/PRESUBMIT.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/perf/measurements/clock_domain_test.py View 1 2 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
rnephew (Reviews Here)
ned for tools/perf bustamante@ for tools/chrome_proxy
3 years, 9 months ago (2017-03-08 23:56:47 UTC) #2
nednguyen
lgtm
3 years, 9 months ago (2017-03-09 00:01:45 UTC) #3
bustamante
On 2017/03/09 00:01:45, nednguyen wrote: > lgtm lgtm
3 years, 9 months ago (2017-03-09 17:03:50 UTC) #4
bustamante
On 2017/03/09 00:01:45, nednguyen wrote: > lgtm lgtm
3 years, 9 months ago (2017-03-09 17:03:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741533003/20001
3 years, 9 months ago (2017-03-09 17:05:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/382055)
3 years, 9 months ago (2017-03-09 17:13:45 UTC) #9
rnephew (Reviews Here)
On 2017/03/09 17:13:45, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 9 months ago (2017-03-09 23:28:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741533003/40001
3 years, 9 months ago (2017-03-09 23:29:47 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 00:34:53 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/aa1f961e37c8778191049bca0260...

Powered by Google App Engine
This is Rietveld 408576698