Fix AshWindowTreeHost shutdown for Ozone X11.

Fix AshWindowTreeHost shutdown for Ozone X11.

AshWindowTreeHostX11 stops receiving XEvents when PrepareForShutdown()
is called to ensure it doesn't get any configuration events after Ash
starts tearing down the RootWindowController. Things like the window
size changing after teardown has started ends up crashing Ash.

We need to do something similar, in a platform independent way for
Ozone, when using the Ozone X11 platform. Add
PlatformWindow::PrepareForShutdown() and call it from
AshWindowTreeHostPlatform::PrepareForShutdown().

BUG=664570
Review-Url: https://codereview.chromium.org/2741533002
Cr-Commit-Position: refs/heads/master@{#455794}
Committed: https://chromium.googlesource.com/chromium/src/+/1fc7c670580371210623e35e09301eda28e656af

[kylechar, 2017-03-08 21:52:27]

kylechar@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2017-03-09 01:54:58]

lgtm

[kylechar, 2017-03-09 14:53:31]

kylechar@chromium.org changed reviewers:
+ jamescook@chromium.org

[kylechar, 2017-03-09 14:53:31]

+jamescook for ash/host/ash_window_tree_host_platform.cc

[kylechar, 2017-03-09 14:57:16]

Description was changed from

==========
Fix AshWindowTreeHost shutdown for Ozone X11.

The AshWindowTreeHostX11 stops receiving XEvents when
PrepareForShutdown() is called to ensure it doesn't get any
configuration events after Ash starts tearing down the
RootWindowController.

We need to do something similar, in a platform independent way, for
Ozone X11. Add PlatformWindow::PrepareForShutdown() and call it from
AshWindowTreeHostPlatform::PrepareForShutdown().

BUG=664570
==========

to

==========
Fix AshWindowTreeHost shutdown for Ozone X11.

AshWindowTreeHostX11 stops receiving XEvents when PrepareForShutdown()
is called to ensure it doesn't get any configuration events after Ash
starts tearing down the RootWindowController. Things like the Window
size being updated after teardown has started ends up crashing Ash.

We need to do something similar, in a platform independent way for
Ozone, when using the Ozone X11 platform. Add
PlatformWindow::PrepareForShutdown() and call it from
AshWindowTreeHostPlatform::PrepareForShutdown().

BUG=664570
==========

[kylechar, 2017-03-09 15:00:10]

Description was changed from

==========
Fix AshWindowTreeHost shutdown for Ozone X11.

AshWindowTreeHostX11 stops receiving XEvents when PrepareForShutdown()
is called to ensure it doesn't get any configuration events after Ash
starts tearing down the RootWindowController. Things like the Window
size being updated after teardown has started ends up crashing Ash.

We need to do something similar, in a platform independent way for
Ozone, when using the Ozone X11 platform. Add
PlatformWindow::PrepareForShutdown() and call it from
AshWindowTreeHostPlatform::PrepareForShutdown().

BUG=664570
==========

to

==========
Fix AshWindowTreeHost shutdown for Ozone X11.

AshWindowTreeHostX11 stops receiving XEvents when PrepareForShutdown()
is called to ensure it doesn't get any configuration events after Ash
starts tearing down the RootWindowController. Things like the window
size chaning after teardown has started ends up crashing Ash.

We need to do something similar, in a platform independent way for
Ozone, when using the Ozone X11 platform. Add
PlatformWindow::PrepareForShutdown() and call it from
AshWindowTreeHostPlatform::PrepareForShutdown().

BUG=664570
==========

[kylechar, 2017-03-09 15:00:19]

Description was changed from

==========
Fix AshWindowTreeHost shutdown for Ozone X11.

AshWindowTreeHostX11 stops receiving XEvents when PrepareForShutdown()
is called to ensure it doesn't get any configuration events after Ash
starts tearing down the RootWindowController. Things like the window
size chaning after teardown has started ends up crashing Ash.

We need to do something similar, in a platform independent way for
Ozone, when using the Ozone X11 platform. Add
PlatformWindow::PrepareForShutdown() and call it from
AshWindowTreeHostPlatform::PrepareForShutdown().

BUG=664570
==========

to

==========
Fix AshWindowTreeHost shutdown for Ozone X11.

AshWindowTreeHostX11 stops receiving XEvents when PrepareForShutdown()
is called to ensure it doesn't get any configuration events after Ash
starts tearing down the RootWindowController. Things like the window
size changing after teardown has started ends up crashing Ash.

We need to do something similar, in a platform independent way for
Ozone, when using the Ozone X11 platform. Add
PlatformWindow::PrepareForShutdown() and call it from
AshWindowTreeHostPlatform::PrepareForShutdown().

BUG=664570
==========

[James Cook, 2017-03-09 15:00:54]

lgtm

[kylechar, 2017-03-09 15:07:02]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[kylechar, 2017-03-09 15:07:08]

Thanks!

[commit-bot: I haz the power, 2017-03-09 15:07:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 15:16:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 15:16:24]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[kylechar, 2017-03-09 15:35:43]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 15:36:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 16:30:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 16:30:34]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-03-09 18:11:37]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-03-09 18:11:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2741533002/#ps20001
(title: "Add to other PlatformWindow implementations.")

[commit-bot: I haz the power, 2017-03-09 18:12:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 18:16:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489083097330230,
"parent_rev": "56da1fdfc0061b0eb2f800ecf7018998098f4e4d", "commit_rev":
"1fc7c670580371210623e35e09301eda28e656af"}

[commit-bot: I haz the power, 2017-03-09 18:17:38]

Description was changed from

==========
Fix AshWindowTreeHost shutdown for Ozone X11.

AshWindowTreeHostX11 stops receiving XEvents when PrepareForShutdown()
is called to ensure it doesn't get any configuration events after Ash
starts tearing down the RootWindowController. Things like the window
size changing after teardown has started ends up crashing Ash.

We need to do something similar, in a platform independent way for
Ozone, when using the Ozone X11 platform. Add
PlatformWindow::PrepareForShutdown() and call it from
AshWindowTreeHostPlatform::PrepareForShutdown().

BUG=664570
==========

to

==========
Fix AshWindowTreeHost shutdown for Ozone X11.

AshWindowTreeHostX11 stops receiving XEvents when PrepareForShutdown()
is called to ensure it doesn't get any configuration events after Ash
starts tearing down the RootWindowController. Things like the window
size changing after teardown has started ends up crashing Ash.

We need to do something similar, in a platform independent way for
Ozone, when using the Ozone X11 platform. Add
PlatformWindow::PrepareForShutdown() and call it from
AshWindowTreeHostPlatform::PrepareForShutdown().

BUG=664570

Review-Url: https://codereview.chromium.org/2741533002
Cr-Commit-Position: refs/heads/master@{#455794}
Committed:
https://chromium.googlesource.com/chromium/src/+/1fc7c670580371210623e35e0930...
==========

[commit-bot: I haz the power, 2017-03-09 18:17:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1fc7c670580371210623e35e0930...