Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2741033002: Call XInitThreads() for single-process mode. (Closed)

Created:
3 years, 9 months ago by kylechar
Modified:
3 years, 9 months ago
Reviewers:
rjkroege, sadrul
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call XInitThreads() for single-process mode. If Ozone X11 is launched for tests in single process mode then it needs to call XInitThreads() as the first call to Xlib. This happens for mus+ash but not during tests. Check |single_process| in InitParams to see if we are initializing Ozone in single process mode. Note that not all tests correctly fill out InitParams. This will have to be fixed as a follow up. BUG=700142 TBR=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2741033002 Cr-Commit-Position: refs/heads/master@{#455908} Committed: https://chromium.googlesource.com/chromium/src/+/a0f4b128a7a670ef3540a33966ebb65a27918520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -16 lines) Patch
A ui/ozone/platform/x11/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/ozone/platform/x11/ozone_platform_x11.cc View 5 chunks +34 lines, -16 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
kylechar
3 years, 9 months ago (2017-03-09 21:11:31 UTC) #3
rjkroege
lgtm
3 years, 9 months ago (2017-03-09 21:29:15 UTC) #4
kylechar
TBR sadrul for DEPS.
3 years, 9 months ago (2017-03-09 22:24:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741033002/1
3 years, 9 months ago (2017-03-09 22:25:06 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 23:54:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a0f4b128a7a670ef3540a33966eb...

Powered by Google App Engine
This is Rietveld 408576698