Issue 2741503002: Hotfix: hasText value is incorrectly set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2741503002: Hotfix: hasText value is incorrectly set (Closed)

Created:
3 years, 9 months ago by EhsanK

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/3029

Project:
chromium

Visibility:
Public.

Hotfix: hasText value is incorrectly set Following the refactoring in CL: 2694543002 the value of hasText is incorrectly set. To be precise, hasText is always set to the negate of its correct value. BUG=602427 Review-Url: https://codereview.chromium.org/2735633005 Cr-Commit-Position: refs/heads/master@{#454901} (cherry picked from commit 6e3e9e553fee7cd6246ac4bd604303e5cdb3694f) Review-Url: https://codereview.chromium.org/2741503002 . Cr-Commit-Position: refs/branch-heads/3029@{#66} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/aab5ba09d5d43ac6bf8875cec9ee89d3c291ac32

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/renderer_host/render_widget_host_view_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

EhsanK

3 years, 9 months ago (2017-03-08 20:25:36 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
aab5ba09d5d43ac6bf8875cec9ee89d3c291ac32.