Move files in wtf/ to platform/wtf/ (Part 5).

Move files in wtf/ to platform/wtf/ (Part 5).

This one actually does not move any files. It moves the definition
of NotNull, currently defined in StdLibExtras.h, to Allocator.h, in
order to make the later process easy.

Why? Because: (1) StdLibExtras.h is part of a big chunk of entangled
interdependencies and (2) the change helps us to disentangle and
makes it easier to relocate Allocator.h.

This CL can also be thought as a refactoring, because StdLibExtras.h
contains many random things that are not really relevant to each other.
It makes more sense to define NotNull in Allocator.h.

BUG=691465
Review-Url: https://codereview.chromium.org/2752293004
Cr-Commit-Position: refs/heads/master@{#458342}
Committed: https://chromium.googlesource.com/chromium/src/+/39b4291858a82f7ea75c4f711efb970aa17b1fe6

[Yuta Kitamura, 2017-03-17 05:11:34]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2017-03-17 05:11:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 05:11:47]

This CL has an open dependency (Issue 2741343017 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Yuta Kitamura, 2017-03-17 05:13:47]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 05:14:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuta Kitamura, 2017-03-17 05:16:38]

yutak@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuta Kitamura, 2017-03-17 05:16:38]

PTAL? (Please review this as an OWNER of platform/)

[commit-bot: I haz the power, 2017-03-17 06:13:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 06:13:24]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[haraken, 2017-03-17 11:47:41]

https://codereview.chromium.org/2752293004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/wtf/NotNull.h (right):

https://codereview.chromium.org/2752293004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/wtf/NotNull.h:33: inline void* operator
new(size_t, NotNullTag, void* location) {

I'm not sure if we want to create a dedicated file for only NotNullTag.

Are you planning to more things to this file? Or would it be an option to move
NotNullTag to Allocator.h?

[Yuta Kitamura, 2017-03-21 02:31:57]

https://codereview.chromium.org/2752293004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/wtf/NotNull.h (right):

https://codereview.chromium.org/2752293004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/wtf/NotNull.h:33: inline void* operator
new(size_t, NotNullTag, void* location) {
On 2017/03/17 11:47:41, haraken wrote:
> 
> I'm not sure if we want to create a dedicated file for only NotNullTag.
> 
> Are you planning to more things to this file? Or would it be an option to move
> NotNullTag to Allocator.h?

I don't really want to put NotNull back to StdLibExtras.h, because
that header is quite messy. Putting NotNull in Allocator.h is certainly
an option, and it may be better than adding a new header.

Let me try to revise the patch...

[Yuta Kitamura, 2017-03-21 03:04:54]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 03:05:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuta Kitamura, 2017-03-21 03:12:47]

Description was changed from

==========
Move files in wtf/ to platform/wtf/ (Part 5).

This one is a bit tricky. This patch actually extracts a part of StdLibExtras.h
and creates a new file called NotNull.h, and then move that file to
platform/wtf/.

This is done this way because (1) StdLibExtras.h is part of a big chunk of
entangled interdependencies and (2) the change helps us to disentangle it
and makes it easy to relocate Allocator.h.

This CL can also be thought as a refactoring, because StdLibExtras.h contains
many random things that are not really relevant to each other. It's nice to
have each utility in an individual header.

BUG=691465
==========

to

==========
Move files in wtf/ to platform/wtf/ (Part 5).

This one actually does not move any files. It moves the definition
of NotNull, currently defined in StdLibExtras.h, to Allocator.h, in
order to make the later process easy.

Why? Because: (1) StdLibExtras.h is part of a big chunk of entangled
interdependencies and (2) the change helps us to disentangle and
makes it easier to relocate Allocator.h.

This CL can also be thought as a refactoring, because StdLibExtras.h
contains many random things that are not really relevant to each other.
It makes more sense to define NotNull in Allocator.h.

BUG=691465
==========

[Yuta Kitamura, 2017-03-21 03:13:11]

haraken: Update the patch and rewrote the change description.
PTAL?

[Yuta Kitamura, 2017-03-21 03:13:11]

haraken: Update the patch and rewrote the change description.
PTAL?

[Yuta Kitamura, 2017-03-21 05:47:38]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 05:47:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-03-21 06:01:06]

LGTM

[commit-bot: I haz the power, 2017-03-21 07:19:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 07:19:01]

Dry run: This issue passed the CQ dry run.

[Yuta Kitamura, 2017-03-21 07:25:42]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2017-03-21 07:26:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 07:31:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490081142547300,
"parent_rev": "73a6b841988d6beecd412bf350e63be47b59f14f", "commit_rev":
"39b4291858a82f7ea75c4f711efb970aa17b1fe6"}

[commit-bot: I haz the power, 2017-03-21 07:32:15]

Description was changed from

==========
Move files in wtf/ to platform/wtf/ (Part 5).

This one actually does not move any files. It moves the definition
of NotNull, currently defined in StdLibExtras.h, to Allocator.h, in
order to make the later process easy.

Why? Because: (1) StdLibExtras.h is part of a big chunk of entangled
interdependencies and (2) the change helps us to disentangle and
makes it easier to relocate Allocator.h.

This CL can also be thought as a refactoring, because StdLibExtras.h
contains many random things that are not really relevant to each other.
It makes more sense to define NotNull in Allocator.h.

BUG=691465
==========

to

==========
Move files in wtf/ to platform/wtf/ (Part 5).

This one actually does not move any files. It moves the definition
of NotNull, currently defined in StdLibExtras.h, to Allocator.h, in
order to make the later process easy.

Why? Because: (1) StdLibExtras.h is part of a big chunk of entangled
interdependencies and (2) the change helps us to disentangle and
makes it easier to relocate Allocator.h.

This CL can also be thought as a refactoring, because StdLibExtras.h
contains many random things that are not really relevant to each other.
It makes more sense to define NotNull in Allocator.h.

BUG=691465

Review-Url: https://codereview.chromium.org/2752293004
Cr-Commit-Position: refs/heads/master@{#458342}
Committed:
https://chromium.googlesource.com/chromium/src/+/39b4291858a82f7ea75c4f711efb...
==========

[commit-bot: I haz the power, 2017-03-21 07:32:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/39b4291858a82f7ea75c4f711efb...