Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2741343002: Fix an issue in fullscreen detector when context is destroyed (Closed)

Created:
3 years, 9 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix an issue in fullscreen detector when context is destroyed There's a race condition causing the WebMediaPlayer to be destroyed before MediaCustomControlsFullscreenDetector dispatches the final change. This CL fixes the issue. BUG=698034 Review-Url: https://codereview.chromium.org/2743573003 Cr-Commit-Position: refs/heads/master@{#456160} (cherry picked from commit ac5c34a5e762fd095bf129de24512100be09872a) Review-Url: https://codereview.chromium.org/2741343002 . Cr-Commit-Position: refs/branch-heads/3029@{#137} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/cca045b0ea07b27182777033f531130b80066575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h View 3 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.cpp View 5 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Zhiqiang Zhang (Slow)
3 years, 9 months ago (2017-03-12 18:36:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cca045b0ea07b27182777033f531130b80066575 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698