Run `git cl format` on all desktop page_info code.

Run `git cl format` on all desktop page_info code.

BUG=700591
TBR=raymes@chromium.org

Review-Url: https://codereview.chromium.org/2741303002
Cr-Commit-Position: refs/heads/master@{#457949}
Committed: https://chromium.googlesource.com/chromium/src/+/1a6300d0b8d32378cf4861f75c84010b1cafe031

[lgarron, 2017-03-11 02:16:43]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 02:17:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 02:20:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 02:20:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[lgarron, 2017-03-16 02:51:29]

lgarron@chromium.org changed reviewers:
+ raymes@chromium.org

[lgarron, 2017-03-16 02:51:30]

raymes@, could you review?

[lgarron, 2017-03-17 19:49:51]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 19:50:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 21:06:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 21:06:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lgarron, 2017-03-17 21:48:04]

lgarron@chromium.org changed reviewers:
+ estark@chromium.org
- raymes@chromium.org

[lgarron, 2017-03-17 21:48:04]

raymes is OOO now.

estark@, could you review?

[lgarron, 2017-03-18 00:37:22]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-18 00:37:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 02:00:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 02:00:12]

Dry run: This issue passed the CQ dry run.

[lgarron, 2017-03-18 03:27:58]

Description was changed from

==========
Run `git cl format` on all desktop page_info code.

BUG=700591
==========

to

==========
Run `git cl format` on all desktop page_info code.

BUG=700591
TBR=raymes@chromium.org
==========

[lgarron, 2017-03-18 03:27:59]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2017-03-18 03:28:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 03:33:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489807679947650,
"parent_rev": "8f0964617b1d3e6abdc4f61e8f1d4b8bf0f6c672", "commit_rev":
"1a6300d0b8d32378cf4861f75c84010b1cafe031"}

[commit-bot: I haz the power, 2017-03-18 03:34:06]

Description was changed from

==========
Run `git cl format` on all desktop page_info code.

BUG=700591
TBR=raymes@chromium.org
==========

to

==========
Run `git cl format` on all desktop page_info code.

BUG=700591
TBR=raymes@chromium.org

Review-Url: https://codereview.chromium.org/2741303002
Cr-Commit-Position: refs/heads/master@{#457949}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a6300d0b8d32378cf4861f75c84...
==========

[commit-bot: I haz the power, 2017-03-18 03:34:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1a6300d0b8d32378cf4861f75c84...

[estark, 2017-03-20 20:09:58]

lgtm, however you generally shouldn't use TBR to land code changes, even
mechanical ones, that haven't been reviewed. See
https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#...,
in particular "This process ensures that all code is reviewed prior to
checkin..."

(In fact I'd even discourage TBR at all on a CL like this, since there's no time
pressure and there's no need to track down many owners, but I suppose that's
probably a matter of personal preference.)

https://codereview.chromium.org/2741303002/diff/20001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/page_info/website_settings_bubble_controller_unittest.mm
(right):

https://codereview.chromium.org/2741303002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/page_info/website_settings_bubble_controller_unittest.mm:64:
CONTENT_SETTINGS_TYPE_IMAGES,         CONTENT_SETTINGS_TYPE_JAVASCRIPT,
This looks really weird... but I guess that's how `git cl format` likes it?

[lgarron, 2017-03-20 22:58:46]

On 2017/03/20 at 20:09:58, estark wrote:
> lgtm, however you generally shouldn't use TBR to land code changes, even
mechanical ones, that haven't been reviewed. See
https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#...,
in particular "This process ensures that all code is reviewed prior to
checkin..."
> 
> (In fact I'd even discourage TBR at all on a CL like this, since there's no
time pressure and there's no need to track down many owners, but I suppose
that's probably a matter of personal preference.)
> 
>
https://codereview.chromium.org/2741303002/diff/20001/chrome/browser/ui/cocoa...
> File
chrome/browser/ui/cocoa/page_info/website_settings_bubble_controller_unittest.mm
(right):
> 
>
https://codereview.chromium.org/2741303002/diff/20001/chrome/browser/ui/cocoa...
>
chrome/browser/ui/cocoa/page_info/website_settings_bubble_controller_unittest.mm:64:
CONTENT_SETTINGS_TYPE_IMAGES,         CONTENT_SETTINGS_TYPE_JAVASCRIPT,
> This looks really weird... but I guess that's how `git cl format` likes it?

*hangs head in shame*

I probably should have set up my CL dependencies differently so that this wasn't
blocking other stuff. Two weeks of rebasing is no fun. :-(

That said, the main flurry for Page Info is almost finished, and I'll make sure
to refrain from TBR even for mechanical stuff in the future.