Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2741103005: Reland of duce copying of local data structures in GeometryMapper and PaintLayerClipper. (Closed)

Created:
3 years, 9 months ago by kinuko
Modified:
3 years, 9 months ago
Reviewers:
pdr., Xianzhu, chrishtr
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, fmalita+watch_chromium.org, jbroman, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of duce copying of local data structures in GeometryMapper and PaintLayerClipper. (patchset #1 id:1 of https://codereview.chromium.org/2743733004/ ) Reason for revert: Was likely a false alarm. Original issue's description: > Revert of Reduce copying of local data structures in GeometryMapper and PaintLayerClipper. (patchset #10 id:170001 of https://codereview.chromium.org/2745563004/ ) > > Reason for revert: > Speculative revert, it doesn't look related but am trying changes in the blame range. > > Will update if the revert has changed things / will revert the revert otherwise. > > https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/9030 > > Test: SitePerProcessHighDPIExpiredCertBrowserTest.InterstitialLoadsWithCorrectDeviceScaleFactor > > Original issue's description: > > Reduce copying of local data structures in GeometryMapper and PaintLayerClipper. > > > > In particular, changes return values from FloatClipRect to const FloatClipRect&, > > to avoid extra data structure copies. > > > > In local testing, this CL produces up to a 10% improvement on the > > rasterize_and_record_micro.partial_invalidation benchmark. > > > > BUG=692614 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > > > Review-Url: https://codereview.chromium.org/2745563004 > > Cr-Commit-Position: refs/heads/master@{#456011} > > Committed: https://chromium.googlesource.com/chromium/src/+/05c00d2035047fa9d210d95afedf8bd063bccc33 > > TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=692614 > > Review-Url: https://codereview.chromium.org/2743733004 > Cr-Commit-Position: refs/heads/master@{#456032} > Committed: https://chromium.googlesource.com/chromium/src/+/a2c9dcac6e64411adf0b6f047125d5ba415cce54 TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=692614 Review-Url: https://codereview.chromium.org/2741103005 Cr-Commit-Position: refs/heads/master@{#456036} Committed: https://chromium.googlesource.com/chromium/src/+/22a37f49e50636144bbae9d5c391d9efbf9c90a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+400 lines, -379 lines) Patch
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 4 chunks +26 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ClipRect.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 2 chunks +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 3 chunks +19 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.h View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 10 chunks +35 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 1 chunk +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 2 chunks +21 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 3 chunks +15 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/FloatClipRect.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h View 8 chunks +50 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp View 9 chunks +115 lines, -130 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp View 9 chunks +78 lines, -71 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kinuko
Created Reland of duce copying of local data structures in GeometryMapper and PaintLayerClipper.
3 years, 9 months ago (2017-03-10 10:33:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741103005/1
3 years, 9 months ago (2017-03-10 10:33:55 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 10:35:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/22a37f49e50636144bbae9d5c391...

Powered by Google App Engine
This is Rietveld 408576698