DescriptionReland of duce copying of local data structures in GeometryMapper and PaintLayerClipper. (patchset #1 id:1 of https://codereview.chromium.org/2743733004/ )
Reason for revert:
Was likely a false alarm.
Original issue's description:
> Revert of Reduce copying of local data structures in GeometryMapper and PaintLayerClipper. (patchset #10 id:170001 of https://codereview.chromium.org/2745563004/ )
>
> Reason for revert:
> Speculative revert, it doesn't look related but am trying changes in the blame range.
>
> Will update if the revert has changed things / will revert the revert otherwise.
>
> https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/9030
>
> Test: SitePerProcessHighDPIExpiredCertBrowserTest.InterstitialLoadsWithCorrectDeviceScaleFactor
>
> Original issue's description:
> > Reduce copying of local data structures in GeometryMapper and PaintLayerClipper.
> >
> > In particular, changes return values from FloatClipRect to const FloatClipRect&,
> > to avoid extra data structure copies.
> >
> > In local testing, this CL produces up to a 10% improvement on the
> > rasterize_and_record_micro.partial_invalidation benchmark.
> >
> > BUG=692614
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> >
> > Review-Url: https://codereview.chromium.org/2745563004
> > Cr-Commit-Position: refs/heads/master@{#456011}
> > Committed: https://chromium.googlesource.com/chromium/src/+/05c00d2035047fa9d210d95afedf8bd063bccc33
>
> TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=692614
>
> Review-Url: https://codereview.chromium.org/2743733004
> Cr-Commit-Position: refs/heads/master@{#456032}
> Committed: https://chromium.googlesource.com/chromium/src/+/a2c9dcac6e64411adf0b6f047125d5ba415cce54
TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692614
Review-Url: https://codereview.chromium.org/2741103005
Cr-Commit-Position: refs/heads/master@{#456036}
Committed: https://chromium.googlesource.com/chromium/src/+/22a37f49e50636144bbae9d5c391d9efbf9c90a6
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|