Stability file flushing: replace experiment by parameter

Stability file flushing: replace experiment by parameter

https://crrev.com/2720353002 attempted to experiment with flushing by
setting up a second experiment. It is preferable to instead use
experiment parameters.

BUG=620813
Review-Url: https://codereview.chromium.org/2741043005
Cr-Commit-Position: refs/heads/master@{#456466}
Committed: https://chromium.googlesource.com/chromium/src/+/f93b15725455ca57b95e54569a569dae99f3ffa3

[manzagop (departed), 2017-03-10 20:58:07]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 20:58:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[manzagop (departed), 2017-03-10 21:00:31]

manzagop@chromium.org changed reviewers:
+ rkaplow@chromium.org

[manzagop (departed), 2017-03-10 21:00:32]

Hi Rob,
Tell me if this makes more sense!
Thanks,
Pierre

[commit-bot: I haz the power, 2017-03-10 21:47:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 21:47:30]

Dry run: This issue passed the CQ dry run.

[manzagop (departed), 2017-03-13 13:28:40]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 13:28:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 14:38:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 14:38:36]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2017-03-13 15:38:00]

https://codereview.chromium.org/2741043005/diff/20001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_field_trials_desktop.cc (right):

https://codereview.chromium.org/2741043005/diff/20001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_field_trials_desktop.cc:192: const std::string
init_flush_param = base::GetFieldTrialParamValueByFeature(
using GetFieldTrialParamByFeatureAsBool will make your life simpler

[manzagop (departed), 2017-03-13 17:50:51]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 17:51:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[manzagop (departed), 2017-03-13 17:51:26]

Thanks! Another look?

https://codereview.chromium.org/2741043005/diff/20001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_field_trials_desktop.cc (right):

https://codereview.chromium.org/2741043005/diff/20001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_field_trials_desktop.cc:192: const std::string
init_flush_param = base::GetFieldTrialParamValueByFeature(
On 2017/03/13 15:38:00, rkaplow (slow) wrote:
> using GetFieldTrialParamByFeatureAsBool will make your life simpler

Done.

[rkaplow, 2017-03-13 18:42:27]

lgtm

[commit-bot: I haz the power, 2017-03-13 19:03:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 19:03:35]

Dry run: This issue passed the CQ dry run.

[manzagop (departed), 2017-03-13 19:04:33]

The CQ bit was checked by manzagop@chromium.org

[manzagop (departed), 2017-03-13 19:04:47]

Thanks!

[commit-bot: I haz the power, 2017-03-13 19:05:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 20:30:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489431873025280,
"parent_rev": "3c66c935afbaa133537402a41bd619f79920d3ed", "commit_rev":
"f93b15725455ca57b95e54569a569dae99f3ffa3"}

[commit-bot: I haz the power, 2017-03-13 20:31:05]

Description was changed from

==========
Stability file flushing: replace experiment by parameter

https://crrev.com/2720353002 attempted to experiment with flushing by
setting up a second experiment. It is preferable to instead use
experiment parameters.

BUG=620813
==========

to

==========
Stability file flushing: replace experiment by parameter

https://crrev.com/2720353002 attempted to experiment with flushing by
setting up a second experiment. It is preferable to instead use
experiment parameters.

BUG=620813

Review-Url: https://codereview.chromium.org/2741043005
Cr-Commit-Position: refs/heads/master@{#456466}
Committed:
https://chromium.googlesource.com/chromium/src/+/f93b15725455ca57b95e54569a56...
==========

[commit-bot: I haz the power, 2017-03-13 20:31:07]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f93b15725455ca57b95e54569a56...