Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 2741043005: Stability file flushing: replace experiment by parameter (Closed)

Created:
3 years, 9 months ago by manzagop (departed)
Modified:
3 years, 9 months ago
Reviewers:
rkaplow
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stability file flushing: replace experiment by parameter https://crrev.com/2720353002 attempted to experiment with flushing by setting up a second experiment. It is preferable to instead use experiment parameters. BUG=620813 Review-Url: https://codereview.chromium.org/2741043005 Cr-Commit-Position: refs/heads/master@{#456466} Committed: https://chromium.googlesource.com/chromium/src/+/f93b15725455ca57b95e54569a569dae99f3ffa3

Patch Set 1 #

Patch Set 2 : Merge #

Total comments: 2

Patch Set 3 : Address rkaplow's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M chrome/browser/chrome_browser_field_trials_desktop.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M components/browser_watcher/features.h View 1 chunk +6 lines, -1 line 0 comments Download
M components/browser_watcher/features.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
manzagop (departed)
Hi Rob, Tell me if this makes more sense! Thanks, Pierre
3 years, 9 months ago (2017-03-10 21:00:32 UTC) #4
rkaplow
https://codereview.chromium.org/2741043005/diff/20001/chrome/browser/chrome_browser_field_trials_desktop.cc File chrome/browser/chrome_browser_field_trials_desktop.cc (right): https://codereview.chromium.org/2741043005/diff/20001/chrome/browser/chrome_browser_field_trials_desktop.cc#newcode192 chrome/browser/chrome_browser_field_trials_desktop.cc:192: const std::string init_flush_param = base::GetFieldTrialParamValueByFeature( using GetFieldTrialParamByFeatureAsBool will make ...
3 years, 9 months ago (2017-03-13 15:38:00 UTC) #11
manzagop (departed)
Thanks! Another look? https://codereview.chromium.org/2741043005/diff/20001/chrome/browser/chrome_browser_field_trials_desktop.cc File chrome/browser/chrome_browser_field_trials_desktop.cc (right): https://codereview.chromium.org/2741043005/diff/20001/chrome/browser/chrome_browser_field_trials_desktop.cc#newcode192 chrome/browser/chrome_browser_field_trials_desktop.cc:192: const std::string init_flush_param = base::GetFieldTrialParamValueByFeature( On ...
3 years, 9 months ago (2017-03-13 17:51:26 UTC) #14
rkaplow
lgtm
3 years, 9 months ago (2017-03-13 18:42:27 UTC) #15
manzagop (departed)
Thanks!
3 years, 9 months ago (2017-03-13 19:04:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741043005/40001
3 years, 9 months ago (2017-03-13 19:05:01 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 20:31:07 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f93b15725455ca57b95e54569a56...

Powered by Google App Engine
This is Rietveld 408576698