Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5608)

Unified Diff: chrome/browser/chrome_browser_field_trials_desktop.cc

Issue 2741043005: Stability file flushing: replace experiment by parameter (Closed)
Patch Set: Address rkaplow's comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/browser_watcher/features.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_field_trials_desktop.cc
diff --git a/chrome/browser/chrome_browser_field_trials_desktop.cc b/chrome/browser/chrome_browser_field_trials_desktop.cc
index b8b8ecd9fa966071cc7ec447bde03b960e77173e..f81de045e3073981dc9acd4c365fdb98217f50ae 100644
--- a/chrome/browser/chrome_browser_field_trials_desktop.cc
+++ b/chrome/browser/chrome_browser_field_trials_desktop.cc
@@ -16,6 +16,7 @@
#include "base/feature_list.h"
#include "base/files/file_util.h"
#include "base/metrics/field_trial.h"
+#include "base/metrics/field_trial_params.h"
#include "base/metrics/histogram_macros.h"
#include "base/path_service.h"
#include "base/time/time.h"
@@ -187,10 +188,11 @@ void SetupStabilityDebugging() {
// metadata nor does it wait for the changes to be flushed to disk before
// returning. This is an expensive operation. Run as an experiment to
// measure the effect on performance and collection.
- if (base::FeatureList::IsEnabled(
- browser_watcher::kStabilityDebuggingFlushFeature)) {
+ const bool should_flush = base::GetFieldTrialParamByFeatureAsBool(
+ browser_watcher::kStabilityDebuggingFeature,
+ browser_watcher::kInitFlushParam, false);
+ if (should_flush)
::FlushViewOfFile(global_tracker->allocator()->data(), 0U);
- }
}
}
#endif // defined(OS_WIN)
« no previous file with comments | « no previous file | components/browser_watcher/features.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698