Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2741043004: Revert of Add Java wrapper for RenderFrameHost (Closed)

Created:
3 years, 9 months ago by jam
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add Java wrapper for RenderFrameHost (patchset #20 id:630001 of https://codereview.chromium.org/2681933002/ ) Reason for revert: The new test fails with PlzNavigate: https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/247610 I spoke with Bo and he's ok with reverting this for now since nothing depends on it. Please test with PlzNavigate; we're working on getting main waterfall testers in the next day or two. In the meantime, since PlzNavigate is so close to launching we don't want regressions. Apologies that there are no public bots yet. Original issue's description: > Add Java wrapper for RenderFrameHost > > This patch adds a Java wrapper for RenderFrameHost. It also adds a > getMainFrame method to WebContents. > > This will be useful for Payment Request which needs to know > the exact (sub)frame issued the payment request. > > BUG=620173 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2681933002 > Cr-Commit-Position: refs/heads/master@{#455635} > Committed: https://chromium.googlesource.com/chromium/src/+/67dd9f2795389cc3776481ff07740984b2389f43 TBR=rouslan@chromium.org,dcheng@chromium.org,tedchoc@chromium.org,boliu@chromium.org,rob.buis@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=620173 Review-Url: https://codereview.chromium.org/2741043004 Cr-Commit-Position: refs/heads/master@{#455892} Committed: https://chromium.googlesource.com/chromium/src/+/fede5b8ff09c1be5803be0a9f333f5e643d2877a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -314 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D content/browser/frame_host/render_frame_host_android.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/browser/frame_host/render_frame_host_android.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 3 chunks +1 line, -20 lines 0 comments Download
M content/browser/web_contents/web_contents_android.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/android/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostDelegate.java View 1 chunk +0 lines, -11 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java View 1 chunk +0 lines, -49 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 6 chunks +2 lines, -23 lines 0 comments Download
D content/public/android/java/src/org/chromium/content_public/browser/RenderFrameHost.java View 1 chunk +0 lines, -18 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/WebContents.java View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/webcontents/WebContentsTest.java View 2 chunks +0 lines, -30 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jam
Created Revert of Add Java wrapper for RenderFrameHost
3 years, 9 months ago (2017-03-09 22:53:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741043004/1
3 years, 9 months ago (2017-03-09 22:53:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fede5b8ff09c1be5803be0a9f333f5e643d2877a
3 years, 9 months ago (2017-03-09 22:56:52 UTC) #6
please use gerrit instead
Please provide instructions how to run PlzNavigate tests locally.
3 years, 9 months ago (2017-03-09 23:04:32 UTC) #7
boliu
On 2017/03/09 23:04:32, ಠ_ಠ wrote: > Please provide instructions how to run PlzNavigate tests locally. ...
3 years, 9 months ago (2017-03-09 23:07:33 UTC) #8
dcheng
3 years, 9 months ago (2017-03-09 23:07:38 UTC) #9
Message was sent while issue was closed.
On 2017/03/09 23:04:32, ಠ_ಠ wrote:
> Please provide instructions how to run PlzNavigate tests locally.

Passing --enable-browser-side-navigation to the test binary should be
sufficient. The original review has more info in
https://codereview.chromium.org/2681933002/#msg59.

Powered by Google App Engine
This is Rietveld 408576698