Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 2741043004: Revert of Add Java wrapper for RenderFrameHost (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
index ebbbc9be8aae74d174d1411c969cb7c7d546c2a6..e948d064a074f037125f5b8f8c262d99e5a21491 100644
--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
@@ -20,8 +20,6 @@
import org.chromium.base.annotations.JNINamespace;
import org.chromium.content.browser.AppWebMessagePort;
import org.chromium.content.browser.MediaSessionImpl;
-import org.chromium.content.browser.framehost.RenderFrameHostDelegate;
-import org.chromium.content.browser.framehost.RenderFrameHostImpl;
import org.chromium.content_public.browser.AccessibilitySnapshotCallback;
import org.chromium.content_public.browser.AccessibilitySnapshotNode;
import org.chromium.content_public.browser.ContentBitmapCallback;
@@ -29,7 +27,6 @@
import org.chromium.content_public.browser.JavaScriptCallback;
import org.chromium.content_public.browser.MessagePort;
import org.chromium.content_public.browser.NavigationController;
-import org.chromium.content_public.browser.RenderFrameHost;
import org.chromium.content_public.browser.SmartClipCallback;
import org.chromium.content_public.browser.WebContents;
import org.chromium.content_public.browser.WebContentsObserver;
@@ -46,9 +43,9 @@
* object.
*/
@JNINamespace("content")
-// TODO(tedchoc): Remove the package restriction once this class moves to a non-public content
+//TODO(tedchoc): Remove the package restriction once this class moves to a non-public content
// package whose visibility will be enforced via DEPS.
-/* package */ class WebContentsImpl implements WebContents, RenderFrameHostDelegate {
+/* package */ class WebContentsImpl implements WebContents {
private static final String PARCEL_VERSION_KEY = "version";
private static final String PARCEL_WEBCONTENTS_KEY = "webcontents";
private static final String PARCEL_PROCESS_GUARD_KEY = "processguard";
@@ -95,17 +92,8 @@
}
};
- public static WebContents fromRenderFrameHost(RenderFrameHost rfh) {
- RenderFrameHostDelegate delegate = ((RenderFrameHostImpl) rfh).getRenderFrameHostDelegate();
- if (delegate == null || !(delegate instanceof WebContents)) {
- return null;
- }
- return (WebContents) delegate;
- }
-
private long mNativeWebContentsAndroid;
private NavigationController mNavigationController;
- private RenderFrameHost mMainFrame;
// Lazily created proxy observer for handling all Java-based WebContentsObservers.
private WebContentsObserverProxy mObserverProxy;
@@ -181,14 +169,6 @@
@Override
public NavigationController getNavigationController() {
return mNavigationController;
- }
-
- @Override
- public RenderFrameHost getMainFrame() {
- if (mMainFrame == null) {
- mMainFrame = nativeGetMainFrame(mNativeWebContentsAndroid);
- }
- return mMainFrame;
}
@Override
@@ -584,7 +564,6 @@
private static native WebContents nativeFromNativePtr(long webContentsAndroidPtr);
private native WindowAndroid nativeGetTopLevelNativeWindow(long nativeWebContentsAndroid);
- private native RenderFrameHost nativeGetMainFrame(long nativeWebContentsAndroid);
private native String nativeGetTitle(long nativeWebContentsAndroid);
private native String nativeGetVisibleURL(long nativeWebContentsAndroid);
private native boolean nativeIsLoading(long nativeWebContentsAndroid);

Powered by Google App Engine
This is Rietveld 408576698