DevTools: [Icons] do not set background-position in every UI.Icon

DevTools: [Icons] do not set background-position in every UI.Icon

Currently, every UI.Icon sets background-position property in its
element.style.

In case of masks and gradients, this property might actually affect
the gradient position.

This patch starts using --spritesheet-position css variable to
actually set the icon position in the resources.

Drive-by: simplify classes for "force-white-icons".

R=dgozman
BUG=none

Review-Url: https://codereview.chromium.org/2740913003
Cr-Commit-Position: refs/heads/master@{#455972}
Committed: https://chromium.googlesource.com/chromium/src/+/5d6f151a68f7f5d42e6a8337eb38f0ef1cf426e2

[lushnikov, 2017-03-09 23:21:36]

please, take a look

[lushnikov, 2017-03-09 23:21:40]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 23:22:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-03-09 23:45:34]

lgtm

https://codereview.chromium.org/2740913003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css
(right):

https://codereview.chromium.org/2740913003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css:377:
background: white !important;
-webkit-mask-position it.

[lushnikov, 2017-03-09 23:48:38]

https://codereview.chromium.org/2740913003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css
(right):

https://codereview.chromium.org/2740913003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css:377:
background: white !important;
On 2017/03/09 23:45:34, dgozman wrote:
> -webkit-mask-position it.

Done.

[lushnikov, 2017-03-10 01:32:45]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-03-10 01:32:46]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2740913003/#ps40001
(title: "fix suggestbox")

[commit-bot: I haz the power, 2017-03-10 01:33:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 03:04:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489109565908930,
"parent_rev": "8217d3c2acd05f9d5d5131b4f54743f231bc53a4", "commit_rev":
"5d6f151a68f7f5d42e6a8337eb38f0ef1cf426e2"}

[commit-bot: I haz the power, 2017-03-10 03:05:36]

Description was changed from

==========
DevTools: [Icons] do not set background-position in every UI.Icon

Currently, every UI.Icon sets background-position property in its
element.style.

In case of masks and gradients, this property might actually affect
the gradient position.

This patch starts using --spritesheet-position css variable to
actually set the icon position in the resources.

Drive-by: simplify classes for "force-white-icons".

R=dgozman
BUG=none
==========

to

==========
DevTools: [Icons] do not set background-position in every UI.Icon

Currently, every UI.Icon sets background-position property in its
element.style.

In case of masks and gradients, this property might actually affect
the gradient position.

This patch starts using --spritesheet-position css variable to
actually set the icon position in the resources.

Drive-by: simplify classes for "force-white-icons".

R=dgozman
BUG=none

Review-Url: https://codereview.chromium.org/2740913003
Cr-Commit-Position: refs/heads/master@{#455972}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d6f151a68f7f5d42e6a8337eb38...
==========

[commit-bot: I haz the power, 2017-03-10 03:05:37]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5d6f151a68f7f5d42e6a8337eb38...