Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Icon.js

Issue 2740913003: DevTools: [Icons] do not set background-position in every UI.Icon (Closed)
Patch Set: fix suggestbox Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui/Icon.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Icon.js b/third_party/WebKit/Source/devtools/front_end/ui/Icon.js
index edbcaae3a34718bd2636d6c999b3964ce80cf384..e8e074872ae17579d4f3c0faa9cda137b885d758 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/Icon.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/Icon.js
@@ -44,8 +44,7 @@ UI.Icon = class extends HTMLSpanElement {
*/
setIconType(iconType) {
if (this._descriptor) {
- this.style.removeProperty('-webkit-mask-position');
- this.style.removeProperty('background-position');
+ this.style.removeProperty('--spritesheet-position');
this.style.removeProperty('width');
this.style.removeProperty('height');
this._toggleClasses(false);
@@ -56,8 +55,7 @@ UI.Icon = class extends HTMLSpanElement {
if (descriptor) {
this._iconType = iconType;
this._descriptor = descriptor;
- this.style.setProperty('-webkit-mask-position', this._propertyValue());
- this.style.setProperty('background-position', this._propertyValue());
+ this.style.setProperty('--spritesheet-position', this._propertyValue());
this.style.setProperty('width', this._descriptor.width + 'px');
this.style.setProperty('height', this._descriptor.height + 'px');
this._toggleClasses(true);
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698