Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2740913002: Do not disable V8's LiveEdit on startup. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
kozy, haraken, marja
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not disable V8's LiveEdit on startup. This is being done by default in V8 itself. The API used to do this is being deprecated. R=marja@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2740913002 Cr-Commit-Position: refs/heads/master@{#455695} Committed: https://chromium.googlesource.com/chromium/src/+/319373dd4fdc7b2ab5db402844765f3dd9613bda

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Yang
On 2017/03/09 05:59:33, Yang wrote: > Description was changed from > > ========== > Do ...
3 years, 9 months ago (2017-03-09 06:01:14 UTC) #2
kozy
lgtm
3 years, 9 months ago (2017-03-09 06:02:51 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-03-09 07:56:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740913002/1
3 years, 9 months ago (2017-03-09 08:05:31 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 08:11:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/319373dd4fdc7b2ab5db40284476...

Powered by Google App Engine
This is Rietveld 408576698