Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2740913002: Do not disable V8's LiveEdit on startup. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 359 matching lines...) Expand 10 before | Expand all | Expand 10 after
370 static void initializeV8Common(v8::Isolate* isolate) { 370 static void initializeV8Common(v8::Isolate* isolate) {
371 isolate->AddGCPrologueCallback(V8GCController::gcPrologue); 371 isolate->AddGCPrologueCallback(V8GCController::gcPrologue);
372 isolate->AddGCEpilogueCallback(V8GCController::gcEpilogue); 372 isolate->AddGCEpilogueCallback(V8GCController::gcEpilogue);
373 std::unique_ptr<ScriptWrappableVisitor> visitor( 373 std::unique_ptr<ScriptWrappableVisitor> visitor(
374 new ScriptWrappableVisitor(isolate)); 374 new ScriptWrappableVisitor(isolate));
375 V8PerIsolateData::from(isolate)->setScriptWrappableVisitor( 375 V8PerIsolateData::from(isolate)->setScriptWrappableVisitor(
376 std::move(visitor)); 376 std::move(visitor));
377 isolate->SetEmbedderHeapTracer( 377 isolate->SetEmbedderHeapTracer(
378 V8PerIsolateData::from(isolate)->scriptWrappableVisitor()); 378 V8PerIsolateData::from(isolate)->scriptWrappableVisitor());
379 379
380 v8::Debug::SetLiveEditEnabled(isolate, false);
381
382 isolate->SetMicrotasksPolicy(v8::MicrotasksPolicy::kScoped); 380 isolate->SetMicrotasksPolicy(v8::MicrotasksPolicy::kScoped);
383 381
384 isolate->SetUseCounterCallback(&useCounterCallback); 382 isolate->SetUseCounterCallback(&useCounterCallback);
385 } 383 }
386 384
387 namespace { 385 namespace {
388 386
389 class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator { 387 class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
390 // Allocate() methods return null to signal allocation failure to V8, which 388 // Allocate() methods return null to signal allocation failure to V8, which
391 // should respond by throwing a RangeError, per 389 // should respond by throwing a RangeError, per
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
560 v8::Isolate::kMessageLog); 558 v8::Isolate::kMessageLog);
561 isolate->SetFatalErrorHandler(reportFatalErrorInWorker); 559 isolate->SetFatalErrorHandler(reportFatalErrorInWorker);
562 560
563 uint32_t here; 561 uint32_t here;
564 isolate->SetStackLimit(reinterpret_cast<uintptr_t>(&here) - 562 isolate->SetStackLimit(reinterpret_cast<uintptr_t>(&here) -
565 kWorkerMaxStackSize); 563 kWorkerMaxStackSize);
566 isolate->SetPromiseRejectCallback(promiseRejectHandlerInWorker); 564 isolate->SetPromiseRejectCallback(promiseRejectHandlerInWorker);
567 } 565 }
568 566
569 } // namespace blink 567 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698