Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h

Issue 2740603003: Hide SpellCheckRequest from other classes in editing/spellcheck (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h
index 4fd4c54aff61aabed798d6a6a7c7806a92599d24..571760832fe7b0a04057515a59b38df0842e7c30 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h
@@ -43,10 +43,11 @@ class LocalFrame;
class SpellCheckRequester;
class TextCheckerClient;
+// TODO(xiaochengh): Move this class to dedicated files.
class SpellCheckRequest final : public TextCheckingRequest {
public:
static SpellCheckRequest* create(const EphemeralRange& checkingRange,
- int requestNumber = 0);
yosin_UTC9 2017/03/09 01:28:15 Good! We should avoid to use default parameter.
+ int requestNumber);
~SpellCheckRequest() override;
void dispose();
@@ -87,7 +88,8 @@ class SpellCheckRequester final
~SpellCheckRequester();
DECLARE_TRACE();
- void requestCheckingFor(SpellCheckRequest*);
+ void requestCheckingFor(const EphemeralRange&);
+ void requestCheckingFor(const EphemeralRange&, int requestNum);
void cancelCheck();
int lastRequestSequence() const { return m_lastRequestSequence; }

Powered by Google App Engine
This is Rietveld 408576698