Hide SpellCheckRequest from other classes in editing/spellcheck

third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 25 matching lines @@
 #include "wtf/RefPtr.h"
 #include "wtf/Vector.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
 class LocalFrame;
 class SpellCheckRequester;
 class TextCheckerClient;
 
+// TODO(xiaochengh): Move this class to dedicated files.
 class SpellCheckRequest final : public TextCheckingRequest {
  public:
   static SpellCheckRequest* create(const EphemeralRange& checkingRange,
-                                   int requestNumber = 0);

[yosin_UTC9, 2017/03/09 01:28:15]

Good! We should avoid to use default parameter.

+                                   int requestNumber);
 
   ~SpellCheckRequest() override;
   void dispose();
 
   Range* checkingRange() const { return m_checkingRange; }
   Element* rootEditableElement() const { return m_rootEditableElement; }
 
   void setCheckerAndSequence(SpellCheckRequester*, int sequence);
 
   const TextCheckingRequestData& data() const override;
@@ skipping 20 matching lines @@
   WTF_MAKE_NONCOPYABLE(SpellCheckRequester);
 
  public:
   static SpellCheckRequester* create(LocalFrame& frame) {
     return new SpellCheckRequester(frame);
   }
 
   ~SpellCheckRequester();
   DECLARE_TRACE();
 
-  void requestCheckingFor(SpellCheckRequest*);
+  void requestCheckingFor(const EphemeralRange&);
+  void requestCheckingFor(const EphemeralRange&, int requestNum);
   void cancelCheck();
 
   int lastRequestSequence() const { return m_lastRequestSequence; }
 
   int lastProcessedSequence() const { return m_lastProcessedSequence; }
 
   // Exposed for leak detector only, see comment for corresponding
   // SpellChecker method.
   void prepareForLeakDetection();
 
@@ skipping 25 matching lines @@
 
   Member<SpellCheckRequest> m_processingRequest;
 
   typedef HeapDeque<Member<SpellCheckRequest>> RequestQueue;
   RequestQueue m_requestQueue;
 };
 
 }  // namespace blink
 
 #endif  // SpellCheckRequester_h