third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp - Issue 2740603003: Hide SpellCheckRequest from other classes in editing/spellcheck

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp

Issue 2740603003: Hide SpellCheckRequest from other classes in editing/spellcheck (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h » ('j') | third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp

diff --git a/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp b/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp

index dc8def1b5e6fb6ce551a337b98ed37b4ad57290d..cf0f670b08af7900f5157e453b2fa292417ef904 100644

--- a/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp

+++ b/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp

@@ -173,8 +173,7 @@ void IdleSpellCheckCallback::chunkAndRequestFullCheckingFor(

// Check the full content if it is short.

if (fullLength <= kColdModeChunkSize) {

- SpellCheckRequest* fullRequest = SpellCheckRequest::create(fullRange);

- spellCheckRequester().requestCheckingFor(fullRequest);

+ spellCheckRequester().requestCheckingFor(fullRange);

return;

}

@@ -195,9 +194,7 @@ void IdleSpellCheckCallback::chunkAndRequestFullCheckingFor(

chunkIndex >= 1 ? expandEndToSentenceBoundary(chunkRange)

: expandRangeToSentenceBoundary(chunkRange);

- SpellCheckRequest* chunkRequest =

- SpellCheckRequest::create(checkRange, chunkIndex);

- spellCheckRequester().requestCheckingFor(chunkRequest);

+ spellCheckRequester().requestCheckingFor(checkRange, chunkIndex);

chunkStart = checkRange.endPosition();

}