Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 2740593002: s/isSamePage/isSameDocument in AndroidWebView. (Closed)

Created:
3 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 9 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

s/isSamePage/isSameDocument in AndroidWebView. Old name was presumable used to match was_within_same_page IPC, but SameDocument name better reflects the the type of the navigation (navigation did not change the document object). This change will make naming more consistent with NavigationHandle API: https://codereview.chromium.org/2716493004/ and ContentViewCore API: https://codereview.chromium.org/2735063005/ BUG=695189 Review-Url: https://codereview.chromium.org/2740593002 Cr-Commit-Position: refs/heads/master@{#455467} Committed: https://chromium.googlesource.com/chromium/src/+/02ebf8339c19e2972d49d5fbbade603be652bbec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java View 2 chunks +4 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java View 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Eugene But (OOO till 7-30)
3 years, 9 months ago (2017-03-07 19:56:54 UTC) #7
sgurun-gerrit only
lgtm
3 years, 9 months ago (2017-03-08 16:32:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740593002/1
3 years, 9 months ago (2017-03-08 16:33:13 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 16:37:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02ebf8339c19e2972d49d5fbbade...

Powered by Google App Engine
This is Rietveld 408576698