Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

Issue 2740593002: s/isSamePage/isSameDocument in AndroidWebView. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java b/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java
index ba41b16f7387d5b01293d5f3186b439c644c265f..cd5e29b973e7d15e0b3e6cdf644df7ae93bc8189 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java
@@ -89,7 +89,7 @@ public class AwWebContentsObserver extends WebContentsObserver {
@Override
public void didFinishNavigation(final String url, boolean isInMainFrame, boolean isErrorPage,
- boolean hasCommitted, boolean isSamePage, boolean isFragmentNavigation,
+ boolean hasCommitted, boolean isSameDocument, boolean isFragmentNavigation,
Integer pageTransition, int errorCode, String errorDescription, int httpStatusCode) {
if (errorCode != 0) {
didFailLoad(isInMainFrame, errorCode, errorDescription, url);
@@ -108,9 +108,9 @@ public class AwWebContentsObserver extends WebContentsObserver {
if (!isInMainFrame) return;
- // Only invoke the onPageCommitVisible callback when navigating to a different page,
- // but not when navigating to a different fragment within the same page.
- if (!isSamePage) {
+ // Only invoke the onPageCommitVisible callback when navigating to a different document,
+ // but not when navigating to a different fragment within the same document.
+ if (!isSameDocument) {
ThreadUtils.postOnUiThread(new Runnable() {
@Override
public void run() {
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698