Issue 2740573002: Fix for parsing default parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2740573002: Fix for parsing default parameters. (Closed)

Created:
3 years, 9 months ago by scheglov

Modified:
3 years, 9 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Fix for parsing default parameters. In analyzer we decide whether to create DefaultFormalParameter by the fact of being in [] or {}, not by the fact of presence of a default value. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ed289f64cd9842ff036a4464e8813b1e88b4f265

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -20 lines)			Patch
M	pkg/analyzer/test/generated/parser_fasta_test.dart	View	3 chunks	+6 lines, -16 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_test.dart	View	2 chunks	+38 lines, -0 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart	View	1 chunk	+8 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 9 months ago (2017-03-07 20:20:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ed289f64cd9842ff036a4464e8813b1e88b4f265 (presubmit successful).