Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: pkg/analyzer/test/generated/parser_test.dart

Issue 2740573002: Fix for parsing default parameters. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.test.generated.parser_test; 5 library analyzer.test.generated.parser_test;
6 6
7 import 'package:analyzer/dart/ast/ast.dart'; 7 import 'package:analyzer/dart/ast/ast.dart';
8 import 'package:analyzer/dart/ast/standard_ast_factory.dart'; 8 import 'package:analyzer/dart/ast/standard_ast_factory.dart';
9 import 'package:analyzer/dart/ast/token.dart'; 9 import 'package:analyzer/dart/ast/token.dart';
10 import 'package:analyzer/dart/ast/visitor.dart'; 10 import 'package:analyzer/dart/ast/visitor.dart';
(...skipping 6816 matching lines...) Expand 10 before | Expand all | Expand 10 after
6827 expect(simpleParameter.covariantKeyword, isNull); 6827 expect(simpleParameter.covariantKeyword, isNull);
6828 expect(simpleParameter.identifier, isNotNull); 6828 expect(simpleParameter.identifier, isNotNull);
6829 expect(simpleParameter.keyword, isNull); 6829 expect(simpleParameter.keyword, isNull);
6830 expect(simpleParameter.type, isNotNull); 6830 expect(simpleParameter.type, isNotNull);
6831 expect(simpleParameter.kind, kind); 6831 expect(simpleParameter.kind, kind);
6832 expect(defaultParameter.separator, isNotNull); 6832 expect(defaultParameter.separator, isNotNull);
6833 expect(defaultParameter.defaultValue, isNotNull); 6833 expect(defaultParameter.defaultValue, isNotNull);
6834 expect(defaultParameter.kind, kind); 6834 expect(defaultParameter.kind, kind);
6835 } 6835 }
6836 6836
6837 void test_parseFormalParameter_type_named_noDefault() {
6838 ParameterKind kind = ParameterKind.NAMED;
6839 FormalParameter parameter = parseFormalParameter('A a', kind);
6840 expect(parameter, isNotNull);
6841 assertNoErrors();
6842 expect(parameter, new isInstanceOf<DefaultFormalParameter>());
6843 DefaultFormalParameter defaultParameter = parameter;
6844 SimpleFormalParameter simpleParameter =
6845 defaultParameter.parameter as SimpleFormalParameter;
6846 expect(simpleParameter.covariantKeyword, isNull);
6847 expect(simpleParameter.identifier, isNotNull);
6848 expect(simpleParameter.keyword, isNull);
6849 expect(simpleParameter.type, isNotNull);
6850 expect(simpleParameter.kind, kind);
6851 expect(defaultParameter.separator, isNull);
6852 expect(defaultParameter.defaultValue, isNull);
6853 expect(defaultParameter.kind, kind);
6854 }
6855
6837 void test_parseFormalParameter_type_normal() { 6856 void test_parseFormalParameter_type_normal() {
6838 ParameterKind kind = ParameterKind.REQUIRED; 6857 ParameterKind kind = ParameterKind.REQUIRED;
6839 FormalParameter parameter = parseFormalParameter('A a', kind); 6858 FormalParameter parameter = parseFormalParameter('A a', kind);
6840 expect(parameter, isNotNull); 6859 expect(parameter, isNotNull);
6841 assertNoErrors(); 6860 assertNoErrors();
6842 expect(parameter, new isInstanceOf<SimpleFormalParameter>()); 6861 expect(parameter, new isInstanceOf<SimpleFormalParameter>());
6843 SimpleFormalParameter simpleParameter = parameter; 6862 SimpleFormalParameter simpleParameter = parameter;
6844 expect(simpleParameter.covariantKeyword, isNull); 6863 expect(simpleParameter.covariantKeyword, isNull);
6845 expect(simpleParameter.identifier, isNotNull); 6864 expect(simpleParameter.identifier, isNotNull);
6846 expect(simpleParameter.keyword, isNull); 6865 expect(simpleParameter.keyword, isNull);
(...skipping 13 matching lines...) Expand all
6860 expect(simpleParameter.covariantKeyword, isNull); 6879 expect(simpleParameter.covariantKeyword, isNull);
6861 expect(simpleParameter.identifier, isNotNull); 6880 expect(simpleParameter.identifier, isNotNull);
6862 expect(simpleParameter.keyword, isNull); 6881 expect(simpleParameter.keyword, isNull);
6863 expect(simpleParameter.type, isNotNull); 6882 expect(simpleParameter.type, isNotNull);
6864 expect(simpleParameter.kind, kind); 6883 expect(simpleParameter.kind, kind);
6865 expect(defaultParameter.separator, isNotNull); 6884 expect(defaultParameter.separator, isNotNull);
6866 expect(defaultParameter.defaultValue, isNotNull); 6885 expect(defaultParameter.defaultValue, isNotNull);
6867 expect(defaultParameter.kind, kind); 6886 expect(defaultParameter.kind, kind);
6868 } 6887 }
6869 6888
6889 void test_parseFormalParameter_type_positional_noDefault() {
6890 ParameterKind kind = ParameterKind.POSITIONAL;
6891 FormalParameter parameter = parseFormalParameter('A a', kind);
6892 expect(parameter, isNotNull);
6893 assertNoErrors();
6894 expect(parameter, new isInstanceOf<DefaultFormalParameter>());
6895 DefaultFormalParameter defaultParameter = parameter;
6896 SimpleFormalParameter simpleParameter =
6897 defaultParameter.parameter as SimpleFormalParameter;
6898 expect(simpleParameter.covariantKeyword, isNull);
6899 expect(simpleParameter.identifier, isNotNull);
6900 expect(simpleParameter.keyword, isNull);
6901 expect(simpleParameter.type, isNotNull);
6902 expect(simpleParameter.kind, kind);
6903 expect(defaultParameter.separator, isNull);
6904 expect(defaultParameter.defaultValue, isNull);
6905 expect(defaultParameter.kind, kind);
6906 }
6907
6870 void test_parseFormalParameter_var_named() { 6908 void test_parseFormalParameter_var_named() {
6871 ParameterKind kind = ParameterKind.NAMED; 6909 ParameterKind kind = ParameterKind.NAMED;
6872 FormalParameter parameter = parseFormalParameter('var a : null', kind); 6910 FormalParameter parameter = parseFormalParameter('var a : null', kind);
6873 expect(parameter, isNotNull); 6911 expect(parameter, isNotNull);
6874 assertNoErrors(); 6912 assertNoErrors();
6875 expect(parameter, new isInstanceOf<DefaultFormalParameter>()); 6913 expect(parameter, new isInstanceOf<DefaultFormalParameter>());
6876 DefaultFormalParameter defaultParameter = parameter; 6914 DefaultFormalParameter defaultParameter = parameter;
6877 SimpleFormalParameter simpleParameter = 6915 SimpleFormalParameter simpleParameter =
6878 defaultParameter.parameter as SimpleFormalParameter; 6916 defaultParameter.parameter as SimpleFormalParameter;
6879 expect(simpleParameter.covariantKeyword, isNull); 6917 expect(simpleParameter.covariantKeyword, isNull);
(...skipping 7694 matching lines...) Expand 10 before | Expand all | Expand 10 after
14574 expect(typeAlias.name, isNotNull); 14612 expect(typeAlias.name, isNotNull);
14575 expect(typeAlias.typeParameters, isNull); 14613 expect(typeAlias.typeParameters, isNull);
14576 expect(typeAlias.semicolon, isNotNull); 14614 expect(typeAlias.semicolon, isNotNull);
14577 GenericFunctionType functionType = typeAlias.functionType; 14615 GenericFunctionType functionType = typeAlias.functionType;
14578 expect(functionType, isNotNull); 14616 expect(functionType, isNotNull);
14579 expect(functionType.parameters, isNotNull); 14617 expect(functionType.parameters, isNotNull);
14580 expect(functionType.returnType, isNotNull); 14618 expect(functionType.returnType, isNotNull);
14581 expect(functionType.typeParameters, isNull); 14619 expect(functionType.typeParameters, isNull);
14582 } 14620 }
14583 } 14621 }
OLDNEW
« no previous file with comments | « pkg/analyzer/test/generated/parser_fasta_test.dart ('k') | pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698