Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart

Issue 2740573002: Fix for parsing default parameters. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/generated/parser_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart b/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
index 175ce815a37f718341692f394f63bfc4beff0463..af1af4308680841c753f1e720649e1414569d292 100644
--- a/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
+++ b/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
@@ -637,12 +637,16 @@ class AstBuilder extends ScopeListener {
}
}
- if (defaultValue != null) {
- node = ast.defaultFormalParameter(node, _toAnalyzerParameterKind(kind),
- toAnalyzerToken(defaultValue.separator), defaultValue.value);
+ ParameterKind analyzerKind = _toAnalyzerParameterKind(kind);
+ if (analyzerKind != ParameterKind.REQUIRED) {
+ node = ast.defaultFormalParameter(node, analyzerKind,
+ toAnalyzerToken(defaultValue?.separator), defaultValue?.value);
}
- scope[name.name] = name.staticElement = new AnalyzerParameterElement(node);
+ if (name != null) {
+ scope[name.name] =
+ name.staticElement = new AnalyzerParameterElement(node);
+ }
push(node);
}
« no previous file with comments | « pkg/analyzer/test/generated/parser_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698