Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2740543002: [Gin] Add V8NoTurbo experiment to disable Ignition+TurboFan. (Closed)

Created:
3 years, 9 months ago by rmcilroy
Modified:
3 years, 9 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, machenbach, Michael Starzinger, mvstanton, srahim+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Gin] Add V8NoTurbo experiment to disable Ignition+TurboFan. Adds a V8NoTurbo experiment to disable the new Ignition + TurboFan compiler pipeline. Also changes the description of V8Future to refer to future V8 execution features rather than the new compilation pipeline which will soon be enabled by default. BUG=chromium:692409 Review-Url: https://codereview.chromium.org/2740543002 Cr-Commit-Position: refs/heads/master@{#455259} Committed: https://chromium.googlesource.com/chromium/src/+/0a3bbffbf93db594e56cf32370c78c9a4bafd128

Patch Set 1 #

Patch Set 2 : Add histogram change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M gin/gin_features.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M gin/public/gin_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M gin/v8_initializer.cc View 1 chunk +5 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (18 generated)
rmcilroy
Jochen, PTAL thanks. This relies on https://chromium-review.googlesource.com/c/451320/ which fixes --no-turbo to do what we want ...
3 years, 9 months ago (2017-03-07 14:11:52 UTC) #4
Michael Achenbach
lgtm - no histogram.xml change required?
3 years, 9 months ago (2017-03-07 14:18:19 UTC) #6
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-07 14:31:21 UTC) #7
jochen (gone - plz use gerrit)
if you need an histograms.xml change, please get somebody from the metrics team to approve
3 years, 9 months ago (2017-03-07 14:31:42 UTC) #8
rmcilroy
+jwd - PTAL at histograms.xml change, thanks.
3 years, 9 months ago (2017-03-07 15:07:49 UTC) #15
rmcilroy
Ilya: could you take a look at the histograms.xml change please? We'd like to land ...
3 years, 9 months ago (2017-03-07 21:17:09 UTC) #19
Michael Achenbach
+ more metrics OWNERS for higher likelihood of getting an approval by tomorrow morning, PTAL ...
3 years, 9 months ago (2017-03-07 21:45:33 UTC) #21
rkaplow
lgtm
3 years, 9 months ago (2017-03-07 21:49:04 UTC) #22
rmcilroy
On 2017/03/07 21:49:04, rkaplow (slow) wrote: > lgtm Thanks Robert!
3 years, 9 months ago (2017-03-07 22:29:53 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740543002/20001
3 years, 9 months ago (2017-03-07 22:30:45 UTC) #26
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 22:39:06 UTC) #29
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0a3bbffbf93db594e56cf32370c7...

Powered by Google App Engine
This is Rietveld 408576698