Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: gin/v8_initializer.cc

Issue 2740543002: [Gin] Add V8NoTurbo experiment to disable Ignition+TurboFan. (Closed)
Patch Set: Add histogram change Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/public/gin_features.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/v8_initializer.cc
diff --git a/gin/v8_initializer.cc b/gin/v8_initializer.cc
index 4131f0481e93b71f63059ff053e5a0bf27f358fa..9f7e7013b44a94c91576e28a18134aa10a480a8a 100644
--- a/gin/v8_initializer.cc
+++ b/gin/v8_initializer.cc
@@ -367,7 +367,11 @@ void V8Initializer::Initialize(IsolateHolder::ScriptMode mode,
}
const char* ignition_enabled_crash_key = "N";
- if (base::FeatureList::IsEnabled(features::kV8Future)) {
+ if (base::FeatureList::IsEnabled(features::kV8NoTurbo)) {
+ ignition_enabled_crash_key = "N";
+ std::string flag("--no-turbo");
+ v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
+ } else if (base::FeatureList::IsEnabled(features::kV8Future)) {
ignition_enabled_crash_key = "Y";
std::string flag("--future");
v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
« no previous file with comments | « gin/public/gin_features.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698