Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2740493004: Revert of Move beforeunload hang timer duties to its own timer. (Closed)

Created:
3 years, 9 months ago by tmartino
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move beforeunload hang timer duties to its own timer. (patchset #4 id:60001 of https://codereview.chromium.org/2727253005/ ) Reason for revert: We're seeing reliable failures on Win7 as a result of this patch: BrowserTest.SingleBeforeUnloadAfterRedirect Specific error: [6776:6744:0307/133434.182:FATAL:render_frame_host_impl.cc(2555)] Check failed: is_waiting_for_beforeunload_ack_. Original issue's description: > Move beforeunload hang timer duties to its own timer. > > BUG=418266 > TEST=no user-visible change > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2727253005 > Cr-Commit-Position: refs/heads/master@{#455140} > Committed: https://chromium.googlesource.com/chromium/src/+/ddd4c22cebfb3be9570877a7fcfebeca24c5f83b TBR=creis@chromium.org,dtapuska@chromium.org,avi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=418266 Review-Url: https://codereview.chromium.org/2740493004 Cr-Commit-Position: refs/heads/master@{#455257} Committed: https://chromium.googlesource.com/chromium/src/+/f778ca9f4a958514a2d7e5996eb6433b18410669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -51 lines) Patch
M content/browser/frame_host/render_frame_host_impl.h View 3 chunks +0 lines, -12 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 7 chunks +29 lines, -36 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tmartino
Created Revert of Move beforeunload hang timer duties to its own timer.
3 years, 9 months ago (2017-03-07 22:06:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740493004/1
3 years, 9 months ago (2017-03-07 22:08:03 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 22:35:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f778ca9f4a958514a2d7e5996eb6...

Powered by Google App Engine
This is Rietveld 408576698