Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1745)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2740493004: Revert of Move beforeunload hang timer duties to its own timer. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_widget_host_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 8c44414cbda911773b920c08a7dd79d3a988a60a..6749aafe832138b29352a637eb1107f508b56817 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -4858,6 +4858,16 @@
"ChildProcess.HangRendererType", type,
RendererUnresponsiveType::RENDERER_UNRESPONSIVE_MAX);
+ RenderFrameHostImpl* rfhi =
+ static_cast<RenderFrameHostImpl*>(GetRenderViewHost()->GetMainFrame());
+ if (rfhi->is_waiting_for_beforeunload_ack()) {
+ // If the hang is in the beforeunload handler, pretend the beforeunload
+ // listeners have all fired and allow the delegate to continue closing;
+ // the user will not have the option of cancelling the close.
+ rfhi->SimulateBeforeUnloadAck();
+ return;
+ }
+
if (!GetRenderViewHost() || !GetRenderViewHost()->IsRenderViewLive())
return;
« no previous file with comments | « content/browser/renderer_host/render_widget_host_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698