Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2740463003: [Merge to M58] cros: Fix immersive fullscreen tabstrip revealing does not draw well (Closed)

Created:
3 years, 9 months ago by Qiang(Joe) Xu
Modified:
3 years, 9 months ago
Reviewers:
pkotwicz, sky, Evan Stade
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge to M58] cros: Fix immersive fullscreen tabstrip revealing does not draw well Changes: When OnImmersiveRevealStarted(), if top container's layer is not marked as not filling bounds opaquely, the tabstrip may not draw correctly. It happens when user has theme installed or hovers mouse onto tabstrip. Regression comes from: https://codereview.chromium.org/2674813002. TBR=pkotwicz@chromium.org, sky@chromium.org, estade@chromium.org BUG=697099 TEST=device test bug does not happen Review-Url: https://codereview.chromium.org/2728063002 Cr-Commit-Position: refs/heads/master@{#454896} (cherry picked from commit bc2aafec33859883cdd69a43b301a40a79ce9327) Review-Url: https://codereview.chromium.org/2740463003 . Cr-Commit-Position: refs/branch-heads/3029@{#49} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/a8d551ee7fd1e0621d9b6aeaf40d60c98729e8f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 1 chunk +1 line, -5 lines 0 comments Download
M ui/views/controls/label.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Qiang(Joe) Xu
3 years, 9 months ago (2017-03-07 19:51:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a8d551ee7fd1e0621d9b6aeaf40d60c98729e8f9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698