extensions/renderer/argument_spec.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/argument_spec.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Fix Android Compilation Error Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/argument_spec.cc

diff --git a/extensions/renderer/argument_spec.cc b/extensions/renderer/argument_spec.cc

index 1a9b2ccbb2ef300c87bc3d1c3d5f73e8a4676fd3..8232b6cf6a876dd58219ff4f9859e95cd3625d14 100644

--- a/extensions/renderer/argument_spec.cc

+++ b/extensions/renderer/argument_spec.cc

@@ -59,7 +59,7 @@ void ArgumentSpec::InitializeType(const base::DictionaryValue* dict) {

type_ = ArgumentType::CHOICES;

choices_.reserve(choices->GetSize());

for (const auto& choice : *choices)

- choices_.push_back(base::MakeUnique<ArgumentSpec>(*choice));

+ choices_.push_back(base::MakeUnique<ArgumentSpec>(choice));

return;

}