extensions/renderer/api_signature.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_signature.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Fix Android Compilation Error Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/api_signature.cc

diff --git a/extensions/renderer/api_signature.cc b/extensions/renderer/api_signature.cc

index a76d51bf9f3a56ddf969d18009352f67a88d07ab..4ef7776acf0afaf7989627ae48d9daa056e1618d 100644

--- a/extensions/renderer/api_signature.cc

+++ b/extensions/renderer/api_signature.cc

@@ -221,7 +221,7 @@ APISignature::APISignature(const base::ListValue& specification) {

signature_.reserve(specification.GetSize());

for (const auto& value : specification) {

const base::DictionaryValue* param = nullptr;

- CHECK(value->GetAsDictionary(&param));

+ CHECK(value.GetAsDictionary(&param));

signature_.push_back(base::MakeUnique<ArgumentSpec>(*param));

}