extensions/browser/api/networking_private/networking_private_linux.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_private/networking_private_linux.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Fix Android Compilation Error Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/menu_manager.cc ('K') | « extensions/browser/api/networking_private/networking_private_chromeos.cc ('k') | extensions/browser/api/storage/storage_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_private/networking_private_linux.cc

diff --git a/extensions/browser/api/networking_private/networking_private_linux.cc b/extensions/browser/api/networking_private/networking_private_linux.cc

index 0939d23467a3a8a2c8bce9ea5b6c1e908aee36ef..7c0852d86623983ea9c6da96ac70677df8acfb44 100644

--- a/extensions/browser/api/networking_private/networking_private_linux.cc

+++ b/extensions/browser/api/networking_private/networking_private_linux.cc

@@ -642,8 +642,8 @@ void NetworkingPrivateLinux::SendNetworkListChangedEvent(

for (const auto& network : network_list) {

std::string guid;

- base::DictionaryValue* dict;

- if (network->GetAsDictionary(&dict)) {

+ const base::DictionaryValue* dict;

Devlin 2017/03/30 22:44:59 nit: init to nullptr

jdoerrie 2017/04/07 13:56:17 Done.

+ if (network.GetAsDictionary(&dict)) {

if (dict->GetString(kAccessPointInfoGuid, &guid)) {

guidsForEventCallback.push_back(guid);

}