tools/gn/commands.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/commands.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/commands.cc

diff --git a/tools/gn/commands.cc b/tools/gn/commands.cc

index 39dd079a0622d0e9d32be9d32f1d04deaea2e718..e9691aaa305d50609d75832c464038a60141b7cb 100644

--- a/tools/gn/commands.cc

+++ b/tools/gn/commands.cc

@@ -515,7 +515,7 @@ void FilterAndPrintTargets(bool indent, std::vector<const Target*>* targets) {

FilterAndPrintTargets(targets, &tmp);

for (const auto& value : tmp) {

std::string string;

- value->GetAsString(&string);

+ value.GetAsString(&string);

if (indent)

OutputString(" ");

OutputString(string);