Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/gn/command_desc.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/command_desc.cc
diff --git a/tools/gn/command_desc.cc b/tools/gn/command_desc.cc
index 8e4ebd7e7c0bbc73679ebcce40cca7154751c26b..8dbe6de7de932ec9b67c7cf2219cc6acbf6b8293 100644
--- a/tools/gn/command_desc.cc
+++ b/tools/gn/command_desc.cc
@@ -39,7 +39,7 @@ void PrintValue(const base::Value* value, int indentLevel) {
bool bool_value = false;
if (value->GetAsList(&list_value)) {
for (const auto& v : *list_value) {
- PrintValue(v.get(), indentLevel);
+ PrintValue(&v, indentLevel);
}
} else if (value->GetAsString(&string_value)) {
OutputString(indent);

Powered by Google App Engine
This is Rietveld 408576698