Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Unified Diff: services/catalog/entry.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/catalog/entry.cc
diff --git a/services/catalog/entry.cc b/services/catalog/entry.cc
index 7db2026282d17269715a1b0a24649484209f68fb..2e2836bd21f27f13cfe98cac1504507a61f849f5 100644
--- a/services/catalog/entry.cc
+++ b/services/catalog/entry.cc
@@ -25,7 +25,7 @@ bool ReadStringSet(const base::ListValue& list_value,
DCHECK(string_set);
for (const auto& value_value : list_value) {
std::string value;
- if (!value_value->GetAsString(&value)) {
+ if (!value_value.GetAsString(&value)) {
LOG(ERROR) << "Entry::Deserialize: list member must be a string";
return false;
}

Powered by Google App Engine
This is Rietveld 408576698