net/http/http_server_properties_manager_unittest.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_server_properties_manager_unittest.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_server_properties_manager_unittest.cc

diff --git a/net/http/http_server_properties_manager_unittest.cc b/net/http/http_server_properties_manager_unittest.cc

index 35da22f80a630df82b799f7a1bcf91012f53752f..8d7a248a2b540c41193e4b0bc4ea87ccd1920a11 100644

--- a/net/http/http_server_properties_manager_unittest.cc

+++ b/net/http/http_server_properties_manager_unittest.cc

@@ -1380,7 +1380,7 @@ TEST_P(HttpServerPropertiesManagerTest,

ASSERT_TRUE(pref_dict.GetListWithoutPathExpansion("servers", &servers_list));

base::ListValue::const_iterator it = servers_list->begin();

const base::DictionaryValue* server_pref_dict;

- ASSERT_TRUE((*it)->GetAsDictionary(&server_pref_dict));

+ ASSERT_TRUE(it->GetAsDictionary(&server_pref_dict));

const base::DictionaryValue* example_pref_dict;