Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: net/http/http_server_properties_manager.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_server_properties_manager.cc
diff --git a/net/http/http_server_properties_manager.cc b/net/http/http_server_properties_manager.cc
index 0c3fe871614fa13472e10eca79f8640306ead3cd..bea858b31ef2a75125c9503cba27d08e672bd1b9 100644
--- a/net/http/http_server_properties_manager.cc
+++ b/net/http/http_server_properties_manager.cc
@@ -483,7 +483,7 @@ void HttpServerPropertiesManager::UpdateCacheFromPrefsOnPrefThread() {
} else {
for (base::ListValue::const_iterator it = servers_list->begin();
it != servers_list->end(); ++it) {
- if (!(*it)->GetAsDictionary(&servers_dict)) {
+ if (!it->GetAsDictionary(&servers_dict)) {
DVLOG(1) << "Malformed http_server_properties for servers dictionary.";
detected_corrupted_prefs = true;
continue;
@@ -641,7 +641,7 @@ bool HttpServerPropertiesManager::AddToAlternativeServiceMap(
AlternativeServiceInfoVector alternative_service_info_vector;
for (const auto& alternative_service_list_item : *alternative_service_list) {
const base::DictionaryValue* alternative_service_dict;
- if (!alternative_service_list_item->GetAsDictionary(
+ if (!alternative_service_list_item.GetAsDictionary(
&alternative_service_dict))
return false;
AlternativeServiceInfo alternative_service_info;

Powered by Google App Engine
This is Rietveld 408576698