mojo/common/values_struct_traits.h - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/common/values_struct_traits.h

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/common/values_struct_traits.h

diff --git a/mojo/common/values_struct_traits.h b/mojo/common/values_struct_traits.h

index befcf3a6ea2816dd56e56f0a50933d9cec3548e0..0d0cac98ba24bbd3bbd93fb9edf395c071755a71 100644

--- a/mojo/common/values_struct_traits.h

+++ b/mojo/common/values_struct_traits.h

@@ -17,7 +17,7 @@ namespace mojo {

template <>

struct ArrayTraits<base::ListValue> {

- using Element = std::unique_ptr<base::Value>;

+ using Element = base::Value;

using ConstIterator = base::ListValue::const_iterator;

static size_t GetSize(const base::ListValue& input) {