Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: ipc/ipc_message_utils.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/ipc_message_utils.cc
diff --git a/ipc/ipc_message_utils.cc b/ipc/ipc_message_utils.cc
index bf8daa5d9741189df50bdac48f7b39cf5744e5a2..56d170f869a2d1c763fa943f00e1717b156086ab 100644
--- a/ipc/ipc_message_utils.cc
+++ b/ipc/ipc_message_utils.cc
@@ -128,7 +128,7 @@ void GetValueSize(base::PickleSizer* sizer,
sizer->AddInt();
const base::ListValue* list = static_cast<const base::ListValue*>(value);
for (const auto& entry : *list) {
- GetValueSize(sizer, entry.get(), recursion + 1);
+ GetValueSize(sizer, &entry, recursion + 1);
}
break;
}
@@ -198,7 +198,7 @@ void WriteValue(base::Pickle* m, const base::Value* value, int recursion) {
const base::ListValue* list = static_cast<const base::ListValue*>(value);
WriteParam(m, static_cast<int>(list->GetSize()));
for (const auto& entry : *list) {
- WriteValue(m, entry.get(), recursion + 1);
+ WriteValue(m, &entry, recursion + 1);
}
break;
}

Powered by Google App Engine
This is Rietveld 408576698