google_apis/gaia/gaia_auth_fetcher.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/gaia_auth_fetcher.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gaia/gaia_auth_fetcher.cc

diff --git a/google_apis/gaia/gaia_auth_fetcher.cc b/google_apis/gaia/gaia_auth_fetcher.cc

index 03bd8a4526d4b3ac930b2a06f26528ce67402351..c5c3f1c71d0a8d1eb7841503d12646490e4ed4ab 100644

--- a/google_apis/gaia/gaia_auth_fetcher.cc

+++ b/google_apis/gaia/gaia_auth_fetcher.cc

@@ -499,7 +499,7 @@ bool GaiaAuthFetcher::ParseListIdpSessionsResponse(const std::string& data,

iter != sessionsList->end();

iter++) {

base::DictionaryValue* sessionDictionary;

- if (!(*iter)->GetAsDictionary(&sessionDictionary))

+ if (!iter->GetAsDictionary(&sessionDictionary))

continue;

if (sessionDictionary->GetString("login_hint", login_hint))