extensions/renderer/dispatcher.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/dispatcher.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/dispatcher.cc

diff --git a/extensions/renderer/dispatcher.cc b/extensions/renderer/dispatcher.cc

index 63e872a26e3d0f4d271f318efa81f44402b9be1f..d78ce5fcb77657a7c7508e5e088180f132aec147 100644

--- a/extensions/renderer/dispatcher.cc

+++ b/extensions/renderer/dispatcher.cc

@@ -156,7 +156,7 @@ void CallModuleMethod(const std::string& module_name,

std::vector<v8::Local<v8::Value>> arguments;

for (const auto& arg : *args) {

- arguments.push_back(converter->ToV8Value(arg.get(), context->v8_context()));

+ arguments.push_back(converter->ToV8Value(&arg, context->v8_context()));

}

context->module_system()->CallModuleMethodSafe(