Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: components/sync_preferences/pref_model_associator.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_preferences/pref_model_associator.cc
diff --git a/components/sync_preferences/pref_model_associator.cc b/components/sync_preferences/pref_model_associator.cc
index 7f893cf94329a78883d36b2316964597b11c8b9a..a0c3d519aa69f4ccff32c668532f11aaf15e1b7d 100644
--- a/components/sync_preferences/pref_model_associator.cc
+++ b/components/sync_preferences/pref_model_associator.cc
@@ -291,7 +291,7 @@ base::Value* PrefModelAssociator::MergeListValues(const base::Value& from_value,
base::ListValue* result = to_list_value.DeepCopy();
for (const auto& value : from_list_value) {
- result->AppendIfNotPresent(value->CreateDeepCopy());
+ result->AppendIfNotPresent(value.CreateDeepCopy());
}
return result;
}

Powered by Google App Engine
This is Rietveld 408576698