components/sync/test/fake_server/fake_server_verifier.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/test/fake_server/fake_server_verifier.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/test/fake_server/fake_server_verifier.cc

diff --git a/components/sync/test/fake_server/fake_server_verifier.cc b/components/sync/test/fake_server/fake_server_verifier.cc

index daccde28b70c60bd04b1e8b7790b7b0597c22ce0..b45bfa3243125f4b6a5d5bb5ba3f926efcd00b5f 100644

--- a/components/sync/test/fake_server/fake_server_verifier.cc

+++ b/components/sync/test/fake_server/fake_server_verifier.cc

@@ -106,7 +106,7 @@ AssertionResult FakeServerVerifier::VerifyEntityCountByTypeAndName(

if (entities->GetList(model_type_string, &entity_list)) {

base::Value name_value(name);

for (const auto& entity : *entity_list) {

- if (name_value.Equals(entity.get()))

+ if (name_value.Equals(&entity))

actual_count++;

}