components/sync/syncable/model_type.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/syncable/model_type.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/syncable/model_type.cc

diff --git a/components/sync/syncable/model_type.cc b/components/sync/syncable/model_type.cc

index b222cd65bab6ab7552cc8a30b1c48351fee8c9d4..d4408f93870205046b4821ff6324f33e86caac31 100644

--- a/components/sync/syncable/model_type.cc

+++ b/components/sync/syncable/model_type.cc

@@ -644,7 +644,7 @@ ModelTypeSet ModelTypeSetFromValue(const base::ListValue& value) {

ModelTypeSet result;

for (base::ListValue::const_iterator i = value.begin(); i != value.end();

++i) {

- result.Put(ModelTypeFromValue(**i));

+ result.Put(ModelTypeFromValue(*i));

}

return result;

}