Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Unified Diff: components/search_engines/template_url_data_util.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/template_url_data_util.cc
diff --git a/components/search_engines/template_url_data_util.cc b/components/search_engines/template_url_data_util.cc
index ab76c92ab576e1bf47e82e7ddd741f12c75bc1f1..fd3138b7bc7aad862d948eb7ed66eda2b0ed2996 100644
--- a/components/search_engines/template_url_data_util.cc
+++ b/components/search_engines/template_url_data_util.cc
@@ -90,7 +90,7 @@ std::unique_ptr<TemplateURLData> TemplateURLDataFromDictionary(
if (dict.GetList(DefaultSearchManager::kAlternateURLs, &alternate_urls)) {
for (const auto& it : *alternate_urls) {
std::string alternate_url;
- if (it->GetAsString(&alternate_url))
+ if (it.GetAsString(&alternate_url))
result->alternate_urls.push_back(std::move(alternate_url));
}
}
@@ -99,7 +99,7 @@ std::unique_ptr<TemplateURLData> TemplateURLDataFromDictionary(
if (dict.GetList(DefaultSearchManager::kInputEncodings, &encodings)) {
for (const auto& it : *encodings) {
std::string encoding;
- if (it->GetAsString(&encoding))
+ if (it.GetAsString(&encoding))
result->input_encodings.push_back(std::move(encoding));
}
}

Powered by Google App Engine
This is Rietveld 408576698