Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: components/signin/core/browser/account_tracker_service.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/account_tracker_service.cc
diff --git a/components/signin/core/browser/account_tracker_service.cc b/components/signin/core/browser/account_tracker_service.cc
index dd3f339588f5271a1768459b8c98207ef76930f0..129b124288cce69c893e1cf8f34592ede9156bc3 100644
--- a/components/signin/core/browser/account_tracker_service.cc
+++ b/components/signin/core/browser/account_tracker_service.cc
@@ -350,7 +350,7 @@ void AccountTrackerService::LoadFromPrefs() {
contains_deprecated_service_flags = true;
std::string flag_string;
for (const auto& flag : *service_flags_list) {
- if (flag->GetAsString(&flag_string) &&
+ if (flag.GetAsString(&flag_string) &&
flag_string == kChildAccountServiceFlag) {
is_child_account = true;
break;
@@ -407,6 +407,8 @@ void AccountTrackerService::SaveToPrefs(const AccountState& state) {
if (!dict) {
dict = new base::DictionaryValue();
update->Append(base::WrapUnique(dict));
+ // |dict| is invalidated at this point, so it needs to be reset.
+ update->GetDictionary(update->GetSize() - 1, &dict);
dict->SetString(kAccountKeyPath, account_id_16);
}

Powered by Google App Engine
This is Rietveld 408576698