Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: components/prefs/pref_member.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/prefs/pref_member.cc
diff --git a/components/prefs/pref_member.cc b/components/prefs/pref_member.cc
index 8ed13ee5516769d8d6bae89089c9ab9115a4667f..f0be267ed5d360d4137bc356127a2f2f26cd7065 100644
--- a/components/prefs/pref_member.cc
+++ b/components/prefs/pref_member.cc
@@ -139,7 +139,7 @@ bool PrefMemberVectorStringUpdate(const base::Value& value,
for (base::ListValue::const_iterator it = list->begin();
it != list->end(); ++it) {
std::string string_value;
- if (!(*it)->GetAsString(&string_value))
+ if (!it->GetAsString(&string_value))
return false;
local_vector.push_back(string_value);

Powered by Google App Engine
This is Rietveld 408576698