Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: chromeos/network/onc/onc_validator.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/onc/onc_validator.cc
diff --git a/chromeos/network/onc/onc_validator.cc b/chromeos/network/onc/onc_validator.cc
index db6efd01244e1dd885703210c9ce34ff21c80846..6bd502b71399c9038f058a710098760299892ecc 100644
--- a/chromeos/network/onc/onc_validator.cc
+++ b/chromeos/network/onc/onc_validator.cc
@@ -244,7 +244,7 @@ bool Validator::ValidateRecommendedField(
std::unique_ptr<base::ListValue> repaired_recommended(new base::ListValue);
for (const auto& entry : *recommended_list) {
std::string field_name;
- if (!entry->GetAsString(&field_name)) {
+ if (!entry.GetAsString(&field_name)) {
NOTREACHED(); // The types of field values are already verified.
continue;
}
@@ -404,7 +404,7 @@ bool Validator::ListFieldContainsValidValues(
path_.push_back(field_name);
for (const auto& entry : *list) {
std::string value;
- if (!entry->GetAsString(&value)) {
+ if (!entry.GetAsString(&value)) {
NOTREACHED(); // The types of field values are already verified.
continue;
}

Powered by Google App Engine
This is Rietveld 408576698