Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: chromeos/network/onc/onc_utils_unittest.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/onc/onc_utils_unittest.cc
diff --git a/chromeos/network/onc/onc_utils_unittest.cc b/chromeos/network/onc/onc_utils_unittest.cc
index ba4a2ed1c66f28dbf22da7003d8458554aea5332..2934df1c18eb115ca36268bd8d2ee5bf4dcb6096 100644
--- a/chromeos/network/onc/onc_utils_unittest.cc
+++ b/chromeos/network/onc/onc_utils_unittest.cc
@@ -179,7 +179,7 @@ TEST(ONCUtils, ProxySettingsToProxyConfig) {
test_data->GetAsList(&tests2);
ASSERT_TRUE(tests2);
for (auto iter1 = tests2->begin(); iter1 != tests2->end(); ++iter1)
- list_of_tests->Append((*iter1)->CreateDeepCopy());
+ list_of_tests->Append(iter1->CreateDeepCopy());
int index = 0;
for (auto iter2 = list_of_tests->begin(); iter2 != list_of_tests->end();
@@ -187,7 +187,7 @@ TEST(ONCUtils, ProxySettingsToProxyConfig) {
SCOPED_TRACE("Test case #" + base::IntToString(index));
base::DictionaryValue* test_case = nullptr;
- (*iter2)->GetAsDictionary(&test_case);
+ iter2->GetAsDictionary(&test_case);
ASSERT_TRUE(test_case);
base::DictionaryValue* onc_proxy_settings;
@@ -216,7 +216,7 @@ TEST(ONCUtils, ProxyConfigToOncProxySettings) {
SCOPED_TRACE("Test case #" + base::IntToString(index));
base::DictionaryValue* test_case;
- (*it)->GetAsDictionary(&test_case);
+ it->GetAsDictionary(&test_case);
base::DictionaryValue* shill_proxy_config;
test_case->GetDictionary("ProxyConfig", &shill_proxy_config);

Powered by Google App Engine
This is Rietveld 408576698