Change base::Value::ListStorage to std::vector<base::Value>

chromecast/crash/linux/crash_testing_utils.cc

Index: chromecast/crash/linux/crash_testing_utils.cc
diff --git a/chromecast/crash/linux/crash_testing_utils.cc b/chromecast/crash/linux/crash_testing_utils.cc
index 4649fc9924fa222d5cae21ebd953222f712c13b0..6ba362fd4658fcc860a4ae97b522e7f3237622be 100644
--- a/chromecast/crash/linux/crash_testing_utils.cc
+++ b/chromecast/crash/linux/crash_testing_utils.cc
@@ -63,7 +63,7 @@ int WriteLockFile(const std::string& path, base::ListValue* contents) {
   std::string lockfile;
 
   for (const auto& elem : *contents) {
-    std::unique_ptr<std::string> dump_info = SerializeToJson(*elem);
+    std::unique_ptr<std::string> dump_info = SerializeToJson(elem);
     RCHECK(dump_info, -1, "Failed to serialize DumpInfo");
     lockfile += *dump_info;
     lockfile += "\n";  // Add line seperatators
@@ -95,7 +95,7 @@ bool FetchDumps(const std::string& lockfile_path,
   dumps->clear();
 
   for (const auto& elem : *dump_list) {
-    std::unique_ptr<DumpInfo> dump(new DumpInfo(elem.get()));
+    std::unique_ptr<DumpInfo> dump(new DumpInfo(&elem));

[brettw, 2017/03/15 22:14:14]

The ownership of this is scary to me. Can you do a quick followup patch to make
the DumpInfo take a "const Value&"?

[jdoerrie, 2017/03/16 19:01:56]

Could you elaborate on what exactly you mean? From my understanding of the code
|DumpInfo| simply forwards the pointer to |ParseEntry| where it copies the
contained strings into private members and does not take ownership of the
pointer
(https://codesearch.chromium.org/chromium/src/chromecast/crash/linux/dump_info...).

[brettw, 2017/03/17 05:39:19]

Yeah, you're right, it's the same as everywhere else. I was imagining DumpInfo
was keeping the pointer.

     RCHECK(dump->valid(), false, "Invalid DumpInfo");
     dumps->push_back(std::move(dump));
   }